Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directionCollideCoverage doesn't find most overlapping node #2435

Closed
jedwards1211 opened this issue Sep 4, 2023 · 1 comment · Fixed by #2440
Closed

directionCollideCoverage doesn't find most overlapping node #2435

jedwards1211 opened this issue Sep 4, 2023 · 1 comment · Fixed by #2440

Comments

@jedwards1211
Copy link
Contributor

Found while working on the code...

overMax needs to be moved outside of the forEach so that directionCollideCoverage returns the node with the most overlap, rather than the last node with >50% overlap

https://github.com/gridstack/gridstack.js/blame/32337b63be0799161f9fd2a763db901c569c3383/src/gridstack-engine.ts#L165
adumesny added a commit to adumesny/gridstack.js that referenced this issue Sep 5, 2023
@adumesny
directionCollideCoverage() tweaks
a747df5 
* fix gridstack#2435 moved overMax outside of loop.
@adumesny adumesny mentioned this issue Sep 5, 2023
Merged
3 tasks
@adumesny
Copy link
Member

adumesny commented Sep 5, 2023

hey thanks, yep makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

directionCollideCoverage() tweaks adumesny/gridstack.js
2 participants
@jedwards1211 @adumesny