-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite Loop, browser freeze when using autoPosition: true, resizing columns #2406
Comments
your example is missing extra.css (to show 2 columns) but I see the inf loop. |
* this was a very particular flow where autoPosition were loading into 1 column (so we save the higher grid count layout) then switch to 2 column, then loaded new items. * also fixed new v9 issue with sizing called with column 1 already.
#2406 inf loop fix adding autoPosition in 1->2 column
fixed in next release. don't forget to donate if you find this lib useful! |
Thank you so much for the speedy response / fix. I'll surely send a dontation as I have found it extremely useful. Keep up the good work |
Subject of the issue
I am adding widgets to the grid (autoPosition:true) and have the ability to resize the columns.
The resizing columns may not be necessary to reproduce this bug but I'm showing the scenario in which I encountered it
When I add a widget, resize the columns, then add another widget, the application / browser window crashes completely
I noticed when not using autoPosition that it behaved normally
Your environment
Gridstack version: 8.4.0
Chrome / Edge / Firefox
Steps to reproduce
Click add widget, then click resize column, then add another widget, browser should freeze
https://jsfiddle.net/zsm039xo/7/
Expected behavior
The infinite loop is caused by findEmptyPosition, the real scope of the issue may extend beyond this function
The text was updated successfully, but these errors were encountered: