Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gs-h="1" removal #2314

Closed
suysie opened this issue May 11, 2023 · 4 comments · Fixed by #2315
Closed

gs-h="1" removal #2314

suysie opened this issue May 11, 2023 · 4 comments · Fixed by #2315
Labels
status:need more info type:bug

Comments

@suysie
Copy link

suysie commented May 11, 2023

Subject of the issue

if a gridstack item is changed to a height of one i get weird behaviour (my content is moved up/outside the item it has something to do with the removal of gs-h="1". the min height is visible in the css in browser but is not working apparently.
image

image

Your environment

  • version of gridstack.js - 8.0.0 and up
  • brave and chrome

Expected behavior

image
example how it should look (this is on version 7.3.0 so works in that version
@adumesny
Copy link
Member

adumesny commented May 12, 2023 •
edited
Loading

yeah I guess setting the height/width is not the same as setting the min size as content can be larger... of course I didn't see that in the demos (I was using the many columns when I figured I could reduce the attr way down some more)

it would be good for you to post an actual example though.

adumesny added a commit to adumesny/gridstack.js that referenced this issue May 13, 2023
@adumesny
fix gs-h|x="1"
3e1aac3 
* fix gridstack#2314
* issue with having min-height/width instead of height/width for gs-h|x="1"
* further compressed CSS multi column rules (use `.gs-# > .grid-stack-item` instead of `.grid-stack-# > .grid-stack-item`)
adumesny added a commit to adumesny/gridstack.js that referenced this issue May 13, 2023
@adumesny
fix gs-h|x="1"
9178fe5 
* fix gridstack#2314
* issue with having min-height/width instead of height/width for gs-h|x="1"
* further compressed CSS multi column rules (use `.gs-# > .grid-stack-item` instead of `.grid-stack-# > .grid-stack-item`)
@adumesny adumesny mentioned this issue May 13, 2023
Merged
3 tasks
@adumesny
Copy link
Member

fixed. don't forget to donate if you find this lib useful!

@LindaBot
Copy link

LindaBot commented Jun 1, 2023

I have updated to 8.2.1 and still seeing this problem in Angular. Anyone else experiencing the same problem?

@adumesny
Copy link
Member

adumesny commented Jun 2, 2023

@LindaBot you need to post a running example for me to debug it at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:need more info type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix gs-h|x="1" adumesny/gridstack.js
3 participants
@adumesny @LindaBot @suysie