-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove min/max CSS #2243
Comments
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this issue
Apr 9, 2023
* fix gridstack#2243 * removed `gs-min|max_w|h` attribute generated in CSS or written out as they are never used for rendering, only for initial load. This reduce our column/row styles in half!
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this issue
Apr 9, 2023
* fix gridstack#2243 * removed `gs-min|max_w|h` attribute generated in CSS or written out as they are never used for rendering, only for initial load. This reduce our column/row styles in half!
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this issue
Apr 9, 2023
*fix gridstack#2243 * also removed `gs-w='1'` and `gs-h='1'` dom attribute writing since we already have min-width/min-height set, no need to set more attributes.
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this issue
Apr 9, 2023
* fix gridstack#2243 * also removed `gs-w='1'` and `gs-h='1'` dom attribute writing since we already have min-width/min-height set, no need to set more attributes.
3 tasks
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this issue
Apr 9, 2023
* more fix gridstack#2243 * remove `'ui-draggable'` and `'ui-resizable'` since wasn't used in CSS and we have the `-disabled` version when off (so we can use `not(xyz-disabled)`).
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this issue
Apr 9, 2023
more fix gridstack#2243
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the issue
today we use CSS for min/max but I really don't see why since the interaction is in code and not using CSS to constrain - might as well only set it during resizing on the clone if at all...
The text was updated successfully, but these errors were encountered: