Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizable handles "w / sw" moves wrong item down the grid #1679

Closed
kevinlandsberg opened this issue Mar 21, 2021 · 5 comments · Fixed by #1688
Closed

Resizable handles "w / sw" moves wrong item down the grid #1679

kevinlandsberg opened this issue Mar 21, 2021 · 5 comments · Fixed by #1688
Labels
type:bug

Comments

@kevinlandsberg
Copy link

kevinlandsberg commented Mar 21, 2021 •
edited
Loading

Subject of the issue

When you are using resizable handles to handle "se", resizing the grid item to the left causes the right grid item to be pushed down. strange behaviour

Your environment

  • 4.0.1 and html5
  • chrome latest

Steps to reproduce

https://jsfiddle.net/kevinlandsberg/tpLhq0jk/26/

Expected behavior

it should push down the left side next grid item and not the item on the right side.

Actual behavior

when you resize the gird item to the left size by using handles "se", it pushed down the grid item on the right side instead of pushing down the grid item in the left side of the resized gird item. strange behaviour...
@adumesny
Copy link
Member

again no idea what you are seeing. include a link and video or pictures... works fine to me.

20210320_182323.mp4

@kevinlandsberg
Copy link
Author

kevinlandsberg commented Mar 21, 2021 •
edited
Loading

@adumesny , sorry for wrong information. Please use GridStackOption: resizable: { handles: "sw" } and try to resize it properly to the left side. Hoe my attached video helps to explain the issue.

screen-capture.mp4

@adumesny
Copy link
Member

please provide a jsfidle sample as the template require.

@kevinlandsberg
Copy link
Author

kevinlandsberg commented Mar 21, 2021 •
edited
Loading

please provide a jsfidle sample as the template require.

https://jsfiddle.net/kevinlandsberg/tpLhq0jk/26/

Please try to resize e.g. third item in direction "sw". Do you see what is happening? Other way round if you resize the item into direction "se", it behaves as expected and looks clean... enough for you to realize the bug?

@adumesny adumesny changed the title Resizable handles "se" moves wront item down the grid Resizable handles "w / sw" moves wrong item down the grid Mar 21, 2021
adumesny added a commit to adumesny/gridstack.js that referenced this issue Mar 27, 2021
@adumesny
collision: Resizable: {handles:'w/sw'} fix
21ab175 
fix gridstack#1679
* 4.x broke the left side size handle (as it needs to move item as well as resize)
now works again and should be more solid too.
@adumesny adumesny mentioned this issue Mar 27, 2021
Merged
3 tasks
@adumesny
Copy link
Member

fixed in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

collision: Resizable: {handles:'w/sw'} fix adumesny/gridstack.js
2 participants
@adumesny @kevinlandsberg