Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All elements collapse to a single row when using cellHeight() #1579

Closed
pyarosh opened this issue Jan 20, 2021 · 0 comments · Fixed by #1580
Closed

All elements collapse to a single row when using cellHeight() #1579

pyarosh opened this issue Jan 20, 2021 · 0 comments · Fixed by #1580

Comments

@pyarosh
Copy link

pyarosh commented Jan 20, 2021

Subject of the issue

Updating element heights with cellHeight() causes all elements in grid to overlay over each other on first row.

Your environment

  • Gridstack v3.1.4 (HTML5)
  • Firefox 84.0.2 AND Chrome 89.0.4384 dev (arm64)

Steps to reproduce

Reproducible by updating cell height with cellHeight() on any of the provided demos.

Expected behavior

Cell Heights on grid should adjust based on parameters in cellHeight()

Actual behavior

Elements from multiple rows collapse into the top row and are all overlayed/stacked on top of each other.
adumesny added a commit to adumesny/gridstack.js that referenced this issue Jan 20, 2021
@adumesny
fix cellHeight() updating CSS for # of rows
0c29630 
* fix gridstack#1579
* make sure to re-create the CSS with actual numer of rows needed when changing cell heights
@adumesny adumesny mentioned this issue Jan 20, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better drag-out/in from below, cellHeight() CSS fix adumesny/gridstack.js
1 participant
@pyarosh