-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website demo Doesn't work on mobile #1413
Comments
likely that touch lib isn't used on the website... I have not tested mobile, but it used to work I was told. Will have to take a look. |
Can confirm that it does not work. Tested on iPadOS 14.0.1 and iOS 12.4.8 and 14.0.1. The hint about using the touch-punch.js didn't worked for me first. The original repo was not updated since 2014. However, I tried the newer fork from https://github.com/RWAP/jquery-ui-touch-punch - which also didn't worked. It throwed an error in the console that it could not find jquery.ui. But JQuery UI is included in gridstack and was indeed loaded. So, I tried to remove the definition from the jquery.ui.touch-punch.js file (from the new repo) in line 22 and then it worked on all my mobile systems. It seems for me, that although JQuery UI is loaded, it cannot be found via "jquery.ui" string. I'm not deep enough into JS to understand why this is here the case. |
@naturtrunken thanks! I might just need to include a patched touch-punch file along with jquery-ui to make it work out of the box (and update the live site). |
I came here to see if this was a known issue. I'm glad there is a solution! Any idea when an update may be available? I'm hyped to incorporate this into a prototype I'm working on. |
@tobias-grasse I know you're using touch-punch.js with no issues so curious what version/fixes you had to make.
|
To be honest return back to a jQuery version is more stable. I am using 0.6.4 and it really good |
@linhtranvu there is no reason you can't use the latest, which still uses jqueryui for drag&drop only (heck even upcoming 3.0 which will have a new html5 native drag&drop will also support legacy jquery-ui if you want). v0.6.4 is 400+ commits behind the latest :) |
I am still having issue with grids having very small height on mobile. I am using gridstack.all.js according to the documentation. I also added jquery-ui-touch-punch but unlike @naturtrunken I am not getting any error in the console but the height issue on mobile devices is not fixed. Any advise will be appreciated. |
@aryatekpia you can set |
Thanks @adumesny for your prompt reply. playing with cellHeight and setting it to something like this grid.cellHeight(grid.cellWidth() * 1.2); fixes the hight on mobile however the problem is that it messes up the x,y position resulting on the grid items to lay on top of each other. |
@aryatekpia please file a separate bug as this is likely NOT a mobile issue, but a oneColumnMode and how you init your grid, or missing some CSS, or... with reproduceable case. If boxes overlap, it's a CSS issue. |
okey thanks I will try to make reproduceable demo. |
Great product. Any idea when the mobile version will be working. Also how do you get the js files from the downloads. It's not clear. Is there a cdn? |
@davidh07 read the doc about npm installing. As for fixing, I have to setup mobile dev testing which I have not done before... |
* for gridstack#1413 * juse JQ version and include before jquery.ui.touch-punch * that MAY fix mobile devices. I have hard time debugging local file so trying to push to live server and see...
copied form original https://github.com/furf/jquery-ui-touch-punch got repo (not maintained since 2014) for gridstack#1413
* fix gridstack#1413 gridstack#444 * we are now using the latest v1.0.8 touch-punch branch from https://github.com/RWAP/jquery-ui-touch-punch and compiling in JQ version (only 188k -> 190k) so mobiles work out of the box * HTML5 v3+ does not currently support `touchmove` events. This will be added in a future release. * added a mobile.html demo showing usage, updated doc/readme
Subject of the issue
Test on both iphone and android phone, none work
Your environment
Steps to reproduce
Use phone to visit gridstackjs website
Expected behaviour
Demo should run
Actual behaviour
No demo work. So current library do not support mobile browser
The text was updated successfully, but these errors were encountered: