Fix textarea height bug

[VaibhavSaini19]

---

Description

This PR fixes #50

Have you read the Contributing Guidelines before opening this PR

 

Yes
Notes for Reviewers

 

---

Screenshot for changes made

 

[gridhead]

Tch. Doesn't work.

[VaibhavSaini19]

Tch. Doesn't work.

Did you try hard-refreshing?

[gridhead]

Held the key combination down to be doubly sure.

…

On Thu, 31 Dec, 2020, 12:29 PM Vaibhav Saini, ***@***.***> wrote: Tch. Doesn't work. Did you try hard-refreshing? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL2O2QVSPFSWXYXYM26YXWTSXQOO3ANCNFSM4VPDZ6UQ> .

[VaibhavSaini19]

@s-katte @shivangswain could you please review?

[s-katte]

This thing works at my end in firefox as well as in chrome

[VaibhavSaini19]

@t0xic0der please check now, i fixed some things

[gridhead]

There's an undue flickering when newlines are added or removed as observed on Firefox. Could you please look into it?

[gridhead]

[gridhead]

The flickering still remains but let's discuss about its nature now. Whenever I am pressing ENTER, the first line heads above the top limit of the text entry field and then falls back to the first line again - which of course is kind of distracting but I suppose the observation might help you debug the issue.

Thanks.

[VaibhavSaini19]

The flickering still remains but let's discuss about its nature now. Whenever I am pressing ENTER, the first line heads above the top limit of the text entry field and then falls back to the first line again - which of course is kind of distracting but I suppose the observation might help you debug the issue.

Thanks.

Well, that's because we are updating all the stuff at onkeyup event. So, when you press, say ENTER, it add a new line, but since we have disabled the resize, the content overflows, and then when the ENTER key is released, it calculates the new scrollHeight and sets that as the new height