RESTful webservice to receive notifications of artifact uploads #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thread thread = new Thread(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| while (true){ |
There was a problem hiding this comment.
I would replaced it with while (!Thread.currentThread().isInterrupted()).
|
Couple of things to be fixed before proceeding with the review:
|
| @@ -18,5 +18,6 @@ | |||
| import com.griddynamics.cd.nrp.internal.model.api.ArtifactMetaInfo; | |||
|
|
|||
| public interface ArtifactUpdateApiClient { | |||
| void sendRequest(ArtifactMetaInfo metaInfo); | |||
| void enqueueRequest(ArtifactMetaInfo artifactMetaInfo); | |||
There was a problem hiding this comment.
Enqueue.. sounds weird :) What about offer(), put() or add()?
gd-tmagrys
force-pushed
the
rest-notifications
branch
5 times, most recently
from
f6d8b25 to
a63b873
Compare
|
I updated commit message and formatting. Also I changed method name. |
| * @param password User's password | ||
| * @return HTTP client | ||
| */ | ||
| private Client getClient(String login, String password) { | ||
| ClientConfig config = new DefaultClientConfig(); | ||
| Client client = Client.create(config); | ||
| client.setExecutorService(asyncRequestsExecutorService); |
There was a problem hiding this comment.
@gd-tmagrys, I am not sure but I think that all Clients will not use the same thread executor. When I tested code without this line separate executor was created for the each client. So that we can not limit threads count.
There was a problem hiding this comment.
Yes, so I'll revert this change and there will be 2 executors:
- first only for this Client
- second for ArtifactMetaInfos from fileBockingQueue and executing this.sendRequest()
gd-tmagrys
force-pushed
the
rest-notifications
branch
2 times, most recently
from
bee795f to
696d6bc
Compare
griddynamics#3 ArtifactUpdateApiClient#offerRequest now does not work in blocking way. Request is being added to internal queue. Background thread iterates through this queue, and submit Runnables to Executor.
gd-tmagrys
force-pushed
the
rest-notifications
branch
from
696d6bc to
3b63c00
Compare
alekseysemenov
added a commit
that referenced
this pull request
Jul 2, 2015
RESTful webservice to receive notifications of artifact uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing issue:
#3
Please review and merge.