Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev tutorials #42

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Dev tutorials #42

merged 5 commits into from
Aug 17, 2020

Conversation

ericneiva
Copy link
Member

Hi, @santiagobadia,

I have gone through the poisson_dev_fe tutorial and applied some changes.

I have a couple of questions:

  1. L234: does not involve allocations?
  2. What is L400 for?

I have already used this tutorial for my own devs. Thanks for preparing it!

Please, review and accept this merge request whenever you have some time. Regards.

@santiagobadia santiagobadia self-requested a review August 17, 2020 08:33
@ericneiva
Copy link
Member Author

I forgot to mention one thing:

L198 I found a little bit confusing that you mentioned the @show withouth invoking it... Maybe the sentence could start with If you use the @show method...

@santiagobadia santiagobadia merged commit 456e514 into gridap:dev-tutorials Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants