-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for distributed discrete geometries #90
Support for distributed discrete geometries #90
Conversation
I think this is ready for a look over. Let me know if anything needs to be adjusted. |
Hi, @zjwegert, I have some time to look into this before the end of the week. Do you need to update anything before the merge? |
Hi @ericneiva, I think this is ready to be looked at. @JordiManyer were there any other changes to incorporate from our recent work? |
I don't think this can be merged. We've been doing quite a lot of changes to accommodate autodiff, and some of the stuff here is no longer needed. I would leave this open for now, with the understanding we'll update changes here when we are done testing things out. |
I agree, let’s do that!
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Jordi Manyer Fuertes ***@***.***>
Sent: Thursday, October 10, 2024 8:57:25 AM
To: gridap/GridapEmbedded.jl ***@***.***>
Cc: Zach Wegert ***@***.***>; Mention ***@***.***>
Subject: Re: [gridap/GridapEmbedded.jl] Support for distributed discrete geometries (PR #90)
I don't think this can be merged. We've been doing quite a lot of changes to accommodate autodiff, and some of the stuff here is no longer needed. I would leave this open for now, with the understanding we'll update changes here when we are done testing things out.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/gridap/GridapEmbedded.jl/pull/90*issuecomment-2403565054__;Iw!!NVzLfOphnbDXSw!GZHjNuR8nXgZtmvPbKVCW7UtmOR39Px5VxAovjaYQ5gNDKxGVL-1MtH1NllJkskgSv0VUrXIO39GUt6263QV6n_Ng_dPf5cflw$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOOWL4PMJ66BJAQ7U7TDO6TZ2WYFLAVCNFSM6AAAAABI6EVSJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGU3DKMBVGQ__;!!NVzLfOphnbDXSw!GZHjNuR8nXgZtmvPbKVCW7UtmOR39Px5VxAovjaYQ5gNDKxGVL-1MtH1NllJkskgSv0VUrXIO39GUt6263QV6n_Ng_dN8Ox7Rw$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Okay, perfect, @zjwegert and @JordiManyer, thanks for the heads up! |
Merge into branch
We will be merging this into a new branch and continuing the work from there. |
Issue #88 and #89