Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: distributed add_tag_from_tags! not working #956

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

JordiManyer
Copy link
Member

add_tag_from_tags! not working for distributed models created from a single serial model in debug mode. This was caused by arrays being aliased. Fixed by copying the arrays.

@amartinhuertas
Copy link
Member

Question: Do we need to solve this in Gridap.jl? In other words, can be instead solve the issue at the place where it is actually needed?

@JordiManyer
Copy link
Member Author

Question: Do we need to solve this in Gridap.jl? In other words, can be instead solve the issue at the place where it is actually needed?

After discussion, we agreed this is actually also good for the serial case. Different model portions should have independent face labelings. Also, the arrays that get copied are tiny.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47271fc) 88.13% compared to head (bc2b47a) 88.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   88.13%   88.14%           
=======================================
  Files         177      177           
  Lines       21062    21064    +2     
=======================================
+ Hits        18564    18566    +2     
  Misses       2498     2498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer merged commit 4a76c17 into master Nov 22, 2023
7 checks passed
@JordiManyer JordiManyer deleted the bugfix-distributed-face-labeling branch November 22, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants