Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Runge-Kutta ODE solver #919

Merged
merged 30 commits into from
Sep 6, 2023
Merged

Update Runge-Kutta ODE solver #919

merged 30 commits into from
Sep 6, 2023

Conversation

oriolcg
Copy link
Member

@oriolcg oriolcg commented Jul 12, 2023

In this PR I modified the Runge-Kutta method in RungeKutta.jl to accommodate TransientFEOperators by adding a new operator type named TransientRungeKuttaFEOperator. This new type allows for a separate definition of the mass and right-hand side operators, as required by the Runge-Kutta scheme.

@oriolcg oriolcg added the enhancement New feature or request label Jul 12, 2023
@oriolcg oriolcg self-assigned this Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #919 (5963fff) into master (0b5dca3) will decrease coverage by 0.13%.
The diff coverage is 78.01%.

❗ Current head 5963fff differs from pull request most recent head 5d71179. Consider uploading reports for the commit 5d71179 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   88.44%   88.31%   -0.13%     
==========================================
  Files         191      174      -17     
  Lines       20652    20397     -255     
==========================================
- Hits        18266    18014     -252     
+ Misses       2386     2383       -3     
Files Changed Coverage Δ
src/ODEs/ODETools/ODESolvers.jl 77.77% <ø> (ø)
src/ODEs/ODETools/ODETools.jl 100.00% <ø> (ø)
src/ODEs/ODETools/Tableaus.jl 63.44% <63.44%> (ø)
src/ODEs/TransientFETools/TransientFEOperators.jl 79.79% <66.96%> (-8.04%) ⬇️
src/ODEs/ODETools/RungeKutta.jl 84.84% <82.25%> (-9.32%) ⬇️
src/ODEs/ODETools/IMEXRungeKutta.jl 100.00% <100.00%> (ø)
src/ODEs/TransientFETools/ODEOperatorInterfaces.jl 100.00% <100.00%> (+6.34%) ⬆️

... and 40 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oriolcg
Copy link
Member Author

oriolcg commented Aug 12, 2023

Hi @santiagobadia, @fverdugo, @amartinhuertas, could any of you take a look at this PR? Thank you!

Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oriolcg!

I see that nothing critical outside the ODEs module was changed. So for me, looks good!

@JordiManyer
Copy link
Member

Hi @oriolcg ,
Could you pull from master and log the changes in NEWS? I'll include these changes in the next release. Thanks!

@JordiManyer JordiManyer merged commit 84b29ad into master Sep 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants