Fix of ConstantFESpace + tests + export #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartinhuertas
approved these changes
Feb 11, 2023
There was a problem hiding this comment.
Hi @janmodderman ! Thanks for the PR! GridapBiotElasticity is a package where this FEspace was originally developed, and thus should not be in Gridap. I have removed the comment.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #872 +/- ##
==========================================
+ Coverage 88.42% 88.56% +0.14%
==========================================
Files 172 172
Lines 19994 19994
==========================================
+ Hits 17679 17707 +28
+ Misses 2315 2287 -28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the function ConstantFESpace to the export, included the test file to the run_test file and fixed some minor things in the ConstantFESpace file. Also, I wasn't sure what the package GridapBiotElasticity is in the test file, so I just commented it out, it runs regardless.
Best regards,
Jan