Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing nedelec on tris #813

Merged
merged 4 commits into from
Jul 13, 2022
Merged

fixing nedelec on tris #813

merged 4 commits into from
Jul 13, 2022

Conversation

santiagobadia
Copy link
Member

No description provided.

@amartinhuertas
Copy link
Member

@santiagobadia ... dont forget to edit the NEWS.md file.

@amartinhuertas
Copy link
Member

@santiagobadia ... dont forget to edit the NEWS.md file.

ok, done

amartinhuertas
amartinhuertas reviewed Jul 13, 2022
View reviewed changes
test/FESpacesTests/CurlConformingFESpacesTests.jl
@@ -43,6 +43,30 @@ dΩ = Measure(Ω,order)
el2 = sqrt(sum( ∫( e⋅e )*dΩ ))
@test el2 < 1.0e-10

order = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have quite a lot of code replication here. Why dont we wrap a single test in a function provided the model and order and call it several times?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this in another PR, there are more tests like this in the file, and it is just a test, no src code

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #813 (0916898) into master (46b5388) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0916898 differs from pull request most recent head ec0798c. Consider uploading reports for the commit ec0798c to get more accurate results

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files         162      162           
  Lines       17993    17993           
=======================================
  Hits        15917    15917           
  Misses       2076     2076
Impacted Files Coverage Δ
src/ReferenceFEs/NedelecRefFEs.jl 91.17% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@santiagobadia santiagobadia merged commit 702f892 into master Jul 13, 2022
@santiagobadia santiagobadia mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartinhuertas amartinhuertas amartinhuertas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santiagobadia @amartinhuertas @codecov-commenter