Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict to active model the evaluation of a FE function at arbitrary points #752

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

ericneiva
Copy link
Member

Please, see related discussion in #747.

@ericneiva ericneiva requested a review from fverdugo March 1, 2022 17:48
@ericneiva ericneiva self-assigned this Mar 1, 2022
@ericneiva ericneiva requested a review from oriolcg March 1, 2022 17:49
@codecov-commenter
Copy link

Codecov Report

Merging #752 (201a297) into master (630f3c6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files         152      152           
  Lines       16595    16595           
=======================================
  Hits        14658    14658           
  Misses       1937     1937           
Impacted Files Coverage Δ
src/CellData/CellFields.jl 89.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630f3c6...201a297. Read the comment docs.

@oriolcg
Copy link
Member

oriolcg commented Mar 1, 2022

This PR looks good to me.

@santiagobadia santiagobadia merged commit 69cfe62 into master Mar 1, 2022
@santiagobadia santiagobadia deleted the interpolate_funs_inside_active_domain branch March 1, 2022 22:59
@ericneiva
Copy link
Member Author

Thanks, @santiagobadia and @oriolcg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants