Div support for fe functions #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consistent with existing approach
…ap.jl into DIV_support_for_fe_functions Conflicts: src/FESpaces/DivConformingFESpaces.jl
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 134 134
Lines 14360 14369 +9
=======================================
+ Hits 12599 12607 +8
- Misses 1761 1762 +1
Continue to review full report at Codecov.
|
…idap/Gridap.jl into DIV_support_for_fe_functions
… DIV_support_for_fe_functions
…_for_fe_functions
…ithub.com:gridap/Gridap.jl into DIV_support_for_fe_functions
…_for_fe_functions
…_for_fe_functions
@fverdugo ... This PR can be reviewed straight away Thanks! |
fverdugo
approved these changes
Sep 8, 2021
|
Hi @fverdugo ... do u think we can release a new patch version with the latest PRs or better to wait for on-going devs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be reviewed straight away