Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laplacian #514

Merged
merged 8 commits into from
Jan 13, 2021
Merged

Laplacian #514

merged 8 commits into from
Jan 13, 2021

Conversation

oriolcg
Copy link
Member

@oriolcg oriolcg commented Jan 11, 2021

This pull request enables the computation of Laplacians. Currently only available for FE with AffineMap.

@oriolcg oriolcg added the enhancement New feature or request label Jan 11, 2021
@oriolcg oriolcg requested a review from fverdugo January 11, 2021 20:33
@oriolcg oriolcg self-assigned this Jan 11, 2021
Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oriolcg, ethanks for the PR!

Can you also add a line into NEWS.md (###Added section)

See my other comment below.

@@ -0,0 +1,54 @@
module BiharmonicTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file being run by the test suite?

It seems that it needs to be included into test/GridapTests/runtests.jl

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 2b7c170

@fverdugo fverdugo merged commit b9ed605 into master Jan 13, 2021
@fverdugo fverdugo deleted the laplacian branch January 13, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants