Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogeneous trial fe space from trial fe space #384

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

oriolcg
Copy link
Member

@oriolcg oriolcg commented Aug 26, 2020

Modifications to enable the construction of an HomogeneousTrialFESpace from a TrialFESpace. This PR solves the issue gridap/GridapODEs.jl#37.

@oriolcg oriolcg requested a review from fverdugo August 26, 2020 12:29
@oriolcg oriolcg added the enhancement New feature or request label Aug 26, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #384 into master will increase coverage by 1.12%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   87.71%   88.83%   +1.12%     
==========================================
  Files         156      156              
  Lines       11010    10094     -916     
==========================================
- Hits         9657     8967     -690     
+ Misses       1353     1127     -226     
Impacted Files Coverage Δ
src/CellData/CellFields.jl 86.91% <33.33%> (-3.04%) ⬇️
src/FESpaces/ExtendedFESpaces.jl 93.12% <100.00%> (-1.20%) ⬇️
src/FESpaces/FECellBases.jl 33.33% <0.00%> (-23.81%) ⬇️
src/Arrays/SubVectors.jl 80.00% <0.00%> (-20.00%) ⬇️
src/Integration/Quadratures.jl 70.00% <0.00%> (-11.82%) ⬇️
src/Arrays/ArrayPairs.jl 81.81% <0.00%> (-11.04%) ⬇️
src/TensorValues/SymFourthOrderTensorValueTypes.jl 64.44% <0.00%> (-10.56%) ⬇️
src/TensorValues/TensorValueTypes.jl 66.66% <0.00%> (-10.15%) ⬇️
src/FESpaces/DirichletFESpaces.jl 90.90% <0.00%> (-9.10%) ⬇️
src/TensorValues/SymTensorValueTypes.jl 56.71% <0.00%> (-8.57%) ⬇️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c4c63...2b9f61f. Read the comment docs.

@fverdugo fverdugo merged commit 0250b13 into master Aug 26, 2020
@fverdugo fverdugo deleted the HomogeneousTrialFESpace_from_trialFESpace branch August 26, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants