Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visualization_data #354

Merged
merged 5 commits into from
Aug 11, 2020
Merged

add visualization_data #354

merged 5 commits into from
Aug 11, 2020

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Aug 11, 2020

No description provided.

@jw3126
Copy link
Contributor Author

jw3126 commented Aug 11, 2020

I added VisualizationData struct. I think we will need to dispatch on something like
AbstractPlotting.plot!(p::Plot(VisualizationData)) later.

@codecov-commenter
Copy link

Codecov Report

Merging #354 into master will decrease coverage by 6.09%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   88.46%   82.37%   -6.10%     
==========================================
  Files         155      141      -14     
  Lines       10447     8481    -1966     
==========================================
- Hits         9242     6986    -2256     
- Misses       1205     1495     +290     
Impacted Files Coverage Δ
src/Visualization/VisualizationData.jl 89.47% <89.47%> (ø)
src/Visualization/Vtk.jl 90.36% <100.00%> (-2.65%) ⬇️
src/Arrays/SubVectors.jl 20.00% <0.00%> (-60.00%) ⬇️
src/Geometry/TriangulationPortions.jl 41.66% <0.00%> (-41.67%) ⬇️
src/Helpers/Macros.jl 25.00% <0.00%> (-37.50%) ⬇️
src/Fields/AffineMaps.jl 64.70% <0.00%> (-35.30%) ⬇️
src/ReferenceFEs/MockDofs.jl 66.66% <0.00%> (-33.34%) ⬇️
src/Fields/ConstantFields.jl 66.66% <0.00%> (-29.77%) ⬇️
src/FESpaces/SingleFieldFEFunctions.jl 63.63% <0.00%> (-27.28%) ⬇️
src/Geometry/GenericBoundaryTriangulations.jl 72.51% <0.00%> (-24.19%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf4682...c8e62ea. Read the comment docs.

@jw3126
Copy link
Contributor Author

jw3126 commented Aug 11, 2020

@fverdugo can you merge this and add me to GridapMakie? I have some code I would like to put there.

@fverdugo fverdugo merged commit 486b66c into gridap:master Aug 11, 2020
@fverdugo
Copy link
Member

Hi @jw3126,

I would like to discuss what we want to put in GridapMakie before granting access. We can discuss it tomorrow e.g. via Gitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants