Bug in outer constructor of Table{...} for input arrays of abstract t…

[amartinhuertas]

…ype.

[codecov-commenter]

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files         153      153           
  Lines       10044    10044           
=======================================
  Hits         8870     8870           
  Misses       1174     1174           

Impacted Files	Coverage Δ
src/Arrays/Tables.jl	87.05% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f333786...c634148. Read the comment docs.

[fverdugo]

@amartinhuertas

Thanks for the PR!

Just a comment: be aware that this fix might allocate new vectors. Perhaps in some contexts instead of using a Table, one could implement and use a more tailored specialization of a vector of vectors in order to avoid this.

[amartinhuertas]

Just a comment: be aware that this fix might allocate new vectors.

Yes, sure!

Perhaps in some contexts instead of using a Table, one could implement and use a more tailored specialization of a vector of vectors in order to avoid this.

Yes. Indeed, due to the fact that members of Table are of type Vector, then Table cannot serve our original purpose in GridapDistributed.jl (i.e., a vector of vectors build as a view of a one dimensional vector). I had to apply an alternative solution not based in the use of Table. In any case, I applied boy scout's rule to fix this issue of Table that I found while reading the code bound to Table.

[fverdugo]

👍
If you have created some struct that is general enough, we can also include it in Gridap so that we can use it in other projects

[amartinhuertas]

If you have created some struct that is general enough, we can also include it in Gridap so that we can use it in other projects

I did not have to create an special structure. Three lines of code are sufficient:

gridap/GridapDistributed.jl@e98d5f4#diff-fb2be2846b38d56cdaf599d624ece152R76

If u feel that this is going to be a recurrent/useful feature, then we can perhaps develop a type extension of AbstractVector