-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periodic BC for cartesian grids #266
Conversation
* Added field isperiodic to cartesian descriptor * Modified constructors of CartesianDescriptor and CartesianDiscreteModel * Added new method for _generate_cell_to_vertices_from_grid in UnstructuredGrids.jl that implements the grid numbering for periodic BC. * Added test PeriodicBC.jl in Geometry tests to check proper numbering of vefs with periodic BC. * Added tests PeriodicDarcy.jl and PeriodicCoupledPoisson.jl to check both with periodic BC.
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 88.94% 89.00% +0.05%
==========================================
Files 147 147
Lines 9604 9646 +42
==========================================
+ Hits 8542 8585 +43
+ Misses 1062 1061 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Please address the last comments in the issue #263 and pull to this branch again for a second review.
* Converted optional arguments of CartesianDescriptor constructors to key-word arguments. * Added deprecated signatures for backwards compatibility. * Uptated tests to use new signatures. * Updated News.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments below. Thanks!
* Minor changes in CartesianDescriptor documentation * Renamed UnstructuredGridTopology used for numbering a grid with periodic BC to _cartesian_grid_topology_with_periodic_bcs. * Moved above function (and related) to CartesianGrids.jl
PR merged! Now, you appear in the list of Gridap contributors. Welcome! |
UnstructuredGrids.jl that implements the grid numbering for periodic BC.
with periodic BC.
with periodic BC.
Minor changes are still required in
CartesianDescriptor
constructors (see issue #263). Apart from that, I would say it is ready to merge.