Merge pull request #934 from HelgeGehring/real_imag_vectorvalue

add real/imag for VectorValue
gridap · Nov 2, 2023 · 86e8101 · 86e8101
2 parents 8ebe624 + b03325c
commit 86e8101
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Added
+
+- Implemented real/imag for VectorValues
+
 ### Fixed
 
 - `BlockMultiFieldStyle` available for `TransientMultiFieldFESpaces` since PR [#946](https://github.com/gridap/Gridap.jl/pull/946).

diff --git a/src/TensorValues/TensorValues.jl b/src/TensorValues/TensorValues.jl
@@ -63,7 +63,7 @@ export data_index
 import Base: show
 import Base: zero, one
 import Base: +, -, *, /, \, ==, ≈, isless
-import Base: conj
+import Base: conj, real, imag
 import Base: sum, maximum, minimum
 import Base: getindex, iterate, eachindex, lastindex
 import Base: size, length, eltype

diff --git a/src/TensorValues/VectorValueTypes.jl b/src/TensorValues/VectorValueTypes.jl
@@ -92,6 +92,9 @@ change_eltype(::VectorValue{D,T1},::Type{T2}) where {D,T1,T2} = change_eltype(Ve
 
 get_array(arg::VectorValue{D,T}) where {D,T} = convert(SVector{D,T}, arg)
 
+real(x::VectorValue{D,<:Complex}) where {D} = VectorValue{D}(real.(x.data))
+imag(x::VectorValue{D,<:Complex}) where {D} = VectorValue{D}(imag.(x.data))
+
 ###############################################################
 # Introspection (VectorValue)
 ###############################################################

diff --git a/test/TensorValuesTests/OperationsTests.jl b/test/TensorValuesTests/OperationsTests.jl
@@ -714,6 +714,14 @@ b = 4.0 - 3.0*im
 @test outer(a,b) == a*b
 @test inner(a,b) == a*b
 
+@test real(VectorValue(1+1im)) == VectorValue(1)
+@test real(VectorValue(1+1im, 1+1im)) == VectorValue(1, 1)
+@test real(VectorValue(1+1im, 1+1im, 1+1im)) == VectorValue(1, 1, 1)
+
+@test imag(VectorValue(1+1im)) == VectorValue(1)
+@test imag(VectorValue(1+1im, 1+1im)) == VectorValue(1, 1)
+@test imag(VectorValue(1+1im, 1+1im, 1+1im)) == VectorValue(1, 1, 1)
+
 # Broadcast
 a = VectorValue(1,2,3)
 b = VectorValue(1.,2.,3.)