Search ignore content of hidden columns #528
Conversation
|
Hi @afshinm , can you look at this pr please ? |
There was a problem hiding this comment.
Thanks for sending this PR @lamilsage. I think it would be better if we could add an option to disable/enable this behavior (and I can see that the default should be "ignore the content").
| import { PluginBaseComponent, PluginBaseProps } from '../../../plugin'; | ||
|
|
||
| export interface SearchConfig { | ||
| keyword?: string; | ||
| enabled?: boolean; | ||
| debounceTimeout?: number; | ||
| selector?: (cell: TCell, rowIndex: number, cellIndex: number) => string; | ||
| columns?: OneDArray<TColumn | string | ComponentChild>; |
There was a problem hiding this comment.
I don't think you need to pass the columns to this component. Columns should be available in this.config.header...
There was a problem hiding this comment.
I did the change you asked. Can you check again please.
There was a problem hiding this comment.
Hi @afshinm , can you recheck the pr please?
… instead of adding a new props
|
Thank you @lamilsage. Could you please update the docs as well? |
@afshinm I don't know where it is |
|
… On Thu, May 6, 2021 at 8:15 AM Laetitia Godeliez ***@***.***> wrote:
Thank you @lamilsage <https://github.com/lamilsage>. Could you please
update the docs as well?
@afshinm <https://github.com/afshinm> I don't know where it is
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#528 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMXVVJRNAYNEU2WE5HFH3TMI6XRANCNFSM434DKHIA>
.
|
|
Hi @afshinm, when do you plan to merge this pr ? |
|
Thanks for the reminder @lamilsage |
|
Hi @afshinm, when do you plan to create a new package version so I can use this feature in my own project ? |
|
@lamilsage sorry I have been busy restructuring the codebase. I will tag and release a new version soon. |
Goal of this pull request is to change the behavior of search plugin with hidden columns.
Currently, when typing a keyword, search plugin look for all cells including hidden one. It make the result a little bit strange to the final user seeing rows that does not contains his keyword.
This change only applies to in memory data (not server side).