#1416: Improve German translations #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitRon
commented
Jan 31, 2024
| @@ -1,22 +1,22 @@ | |||
| export default { | |||
| search: { | |||
| placeholder: 'Geben Sie ein Schlüsselwort ein...', | |||
There was a problem hiding this comment.
this is technically correct but sounds very clunky...
| next: 'Nächste', | ||
| navigate: (page, pages) => `Seite ${page} von ${pages}`, | ||
| page: (page) => `Seite ${page}`, | ||
| showing: 'Anzeigen', | ||
| showing: 'Datensätze', |
There was a problem hiding this comment.
You can't use the "showing x of y" in German, so I had to get a little creative. In the perfect world, the whole "sentence" would be a translatable.
| to: 'zu', | ||
| results: 'Ergebnisse', | ||
| to: 'bis', | ||
| results: 'Ergebnissen', |
| }, | ||
| loading: 'Wird geladen...', | ||
| noRecordsFound: 'Keine übereinstimmenden Aufzeichnungen gefunden', | ||
| noRecordsFound: 'Keine passenden Daten gefunden', |
|
Could anybody please have a look at the changes? Should be a quick one, right? I'm going to use it in production soon and the current translations are a little off 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1416.