Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the TD data type warning #1289

Merged
merged 2 commits into from
Jan 18, 2023
Merged

fix: remove the TD data type warning #1289

merged 2 commits into from
Jan 18, 2023

Conversation

afshinm
Copy link
Member

@afshinm afshinm commented Jan 18, 2023

Remove the cell data type console.warning because a TD should be able render Preact class components (e.g. html(...)). Fixes #1288

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.96% (+0.02% 🔼)
1293/1617
🟡 Branches
66.67% (+0.13% 🔼)
346/519
🟢 Functions 81.05% 278/343
🟡 Lines
79.62% (+0.03% 🔼)
1137/1428

Test suite run success

181 tests passing in 32 suites.

Report generated by 🧪jest coverage report action from 570f132

@github-actions
Copy link

Size Change: -398 B (0%)

Total Size: 93.8 kB

Filename Size Change
dist/gridjs.js 16.2 kB -80 B (0%)
dist/gridjs.module.js 16.2 kB -80 B (0%)
dist/gridjs.production.es.min.js 16.2 kB -80 B (0%)
dist/gridjs.production.min.js 16.2 kB -79 B (0%)
dist/gridjs.umd.js 16.2 kB -79 B (0%)
ℹ️ View Unchanged
Filename Size
l10n/dist/l10n.js 3.05 kB
l10n/dist/l10n.module.js 3.13 kB
l10n/dist/l10n.umd.js 3.18 kB
plugins/selection/dist/selection.js 1.05 kB
plugins/selection/dist/selection.module.js 1.07 kB
plugins/selection/dist/selection.umd.js 1.15 kB

compressed-size-action

@afshinm afshinm merged commit e8d618a into master Jan 18, 2023
@afshinm afshinm deleted the cell-data-type branch January 18, 2023 07:46
@afshinm afshinm added the bug fix Something isn't working label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'HTML in Cell' throws warning when table created from HTML table
1 participant