Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a WorkerImpl subclass to validate the jobType #29

Merged
merged 1 commit into from
Feb 27, 2013

Conversation

michaelcameron
Copy link
Contributor

The Grails Jesque plugin cannot use Jesque 1.3.0 out of the box because of issue 24 (michaelcameron/grails-jesque#24). In short, I had to override the addJobType early on just to loosen the requirement that the jobType class is Runnable or Callable so the job types can just be POGOs and we can follow convention over configuration.

With changes in Jesque 1.3.0 the constructor changed from adding jobTypes directly to the JobType map to calling addJobType. This started a cascade of code that leads to the GrailsWorkerImpl trying to add directly to the jobType map. I think it turns out my implementation of addJobType would never have worked, because it would have received the unmodifiable version returned by WorkerImpl.getJobTypes, but in all cases the jobTypes were set in the constructor (and thus worked in jesque < 1.3.0).

gresrun added a commit that referenced this pull request Feb 27, 2013
Allow a WorkerImpl subclass to validate the jobType
@gresrun gresrun merged commit d0e0ca5 into gresrun:master Feb 27, 2013
@ghost ghost assigned gresrun Feb 27, 2013
@gresrun
Copy link
Owner

gresrun commented Feb 27, 2013

I'll work on getting a 1.3.1 release out this evening for you.

@michaelcameron
Copy link
Contributor Author

Thanks.

@gresrun
Copy link
Owner

gresrun commented Feb 27, 2013

Just cut the 1.3.1 release; should be up in Maven Central in a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants