Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Story globals improvements #12

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 55 additions & 39 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -421,85 +421,101 @@

### New parameters format for addon backgrounds

The `addon-backgrounds` addon now uses a new format for parameters. The `backgrounds` parameter is now an object with a `values` key that contains the background values.
> [!NOTE]
> You need to set the feature flag `backgroundsStoryGlobals` to `true` in your `.storybook/main.ts` to use the new format and set the value with `globals`.

> ! You need to set the feature flag `backgroundsStoryGlobals` to `true` in your `.storybook/main.ts` to use the new format.
The `addon-backgrounds` addon now uses a new format for parameters. The `backgrounds` parameter is now an object with an `options` property that is assigned to an object of background values, where the key is used when setting the global value.

```diff
// .storybook/preview.js
export const parameters = {
backgrounds: {
- values: [
- { name: 'twitter', value: '#00aced' },
- { name: 'facebook', value: '#3b5998' },
- ],
+ options: {
+ twitter: { name: 'twitter', value: '#00aced' },
+ facebook: { name: 'facebook', value: '#3b5998' },
+ },
- values: [
- { name: 'twitter', value: '#00aced' },
- { name: 'facebook', value: '#3b5998' },
- ],
+ options: {
+ twitter: { name: 'Twitter', value: '#00aced' },
+ facebook: { name: 'Facebook', value: '#3b5998' },
+ },
},
};
```

Setting an override value should now be done via a `globals` property on your component/meta or story itself:

```ts
```diff
// Button.stories.ts
export default {
component: Button,
globals: {
backgrounds: { value: 'twitter' },
},
- parameters: {
- backgrounds: {
- default: "twitter",
- },
- },
+ globals: {
+ backgrounds: { value: "twitter" },
+ },
};
```

This locks that story to the `twitter` background, it cannot be changed by the addon UI.

### New parameters format for addon viewport

> ! You need to set the feature flag `viewportStoryGlobals` to `true` in your `.storybook/main.ts` to use the new format.
> [!NOTE]
> You need to set the feature flag `viewportStoryGlobals` to `true` in your `.storybook/main.ts` to use the new format and set the value with `globals`.

The `addon-viewport` addon now uses a new format for parameters. The `viewport` parameter is now an object with a `viewports` key that contains the viewport values.
The `addon-viewport` addon now uses a new format for parameters. The `viewport` parameter is now an object with an `options` property that is assigned to an object of viewport values, where the key is used when setting the global value.

```diff
// .storybook/preview.js
export const parameters = {
viewport: {
- viewports: {
- iphone5: {
- name: 'phone',
- styles: {
- width: '320px',
- height: '568px',
- },
- },
- viewports: {
- iphone5: {
- name: 'phone',
- styles: {
- width: '320px',
- height: '568px',
- },
- },
+ options: {
+ iphone5: {
+ name: 'phone',
+ styles: {
+ width: '320px',
+ height: '568px',
+ },
+ },
+ },
- },
+ options: {
+ iphone5: {
+ name: 'phone',
+ styles: {
+ width: '320px',
+ height: '568px',
+ },
+ },
+ },
},
};
```

Setting an override value should now be done via a `globals` property on your component/meta or story itself:
Setting an override value should now be done via a `globals` property on your component/meta or story itself. Also note the change from `defaultOrientation: "landscape"` to `isRotated: true`.

```ts
```diff
// Button.stories.ts
export default {
component: Button,
globals: {
viewport: { value: 'phone' },
},
- parameters: {
- viewport: {
- defaultViewport: "iphone5",
- defaultOrientation: "landscape",
- },
- },
+ globals: {
+ viewport: {
+ value: "iphone5",
+ isRotated: true,
+ },
+ },
};
```

This locks that story to the `phone` viewport, it cannot be changed by the addon UI.
This locks that story to the `iphone5` viewport in landscape orientation, it cannot be changed by the addon UI.

## From version 8.1.x to 8.2.x

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,21 @@ const meta: Meta<Button> = {
component: Button,
parameters: {
backgrounds: {
options: {
maroon: { name: 'Maroon', value: '#400' },
},
// 👇 Set default background value for all component stories
default: 'Gray',
},
},
};

export default meta;
type Story = StoryObj<Button>;

export const Large: Story = {
global: {
backgrounds: { value: 'maroon', grid: false },
export const OnDark: Story = {
parameters: {
backgrounds: {
// 👇 Override default background value for this story
default: 'Dark',
},
},
};
```
Expand All @@ -31,16 +33,18 @@ export default {
component: Button,
parameters: {
backgrounds: {
options: {
maroon: { name: 'Maroon', value: '#400' },
},
// 👇 Set default background value for all component stories
default: 'Gray',
},
},
};

export const Large = {
global: {
backgrounds: { value: 'maroon', grid: false },
export const OnDark = {
parameters: {
backgrounds: {
// 👇 Override default background value for this story
default: 'Dark',
},
},
};
```
Expand All @@ -55,19 +59,21 @@ const meta = {
component: Button,
parameters: {
backgrounds: {
options: {
maroon: { name: 'Maroon', value: '#400' },
},
// 👇 Set default background value for all component stories
default: 'Gray',
},
},
} satisfies Meta<typeof Button>;

export default meta;
type Story = StoryObj<typeof meta>;

export const Large: Story = {
global: {
backgrounds: { value: 'maroon', grid: false },
export const OnDark: Story = {
parameters: {
backgrounds: {
// 👇 Override default background value for this story
default: 'Dark',
},
},
};
```
Expand All @@ -82,19 +88,21 @@ const meta: Meta<typeof Button> = {
component: Button,
parameters: {
backgrounds: {
options: {
maroon: { name: 'Maroon', value: '#400' },
},
// 👇 Set default background value for all component stories
default: 'Gray',
},
},
};

export default meta;
type Story = StoryObj<typeof Button>;

export const Large: Story = {
global: {
backgrounds: { value: 'maroon', grid: false },
export const OnDark: Story = {
parameters: {
backgrounds: {
// 👇 Override default background value for this story
default: 'Dark',
},
},
};
```
Expand All @@ -104,16 +112,18 @@ export default {
component: 'demo-button',
parameters: {
backgrounds: {
options: {
maroon: { name: 'Maroon', value: '#400' },
},
// 👇 Set default background value for all component stories
default: 'Gray',
},
},
};

export const Large = {
global: {
backgrounds: { value: 'maroon', grid: false },
export const OnDark = {
parameters: {
backgrounds: {
// 👇 Override default background value for this story
default: 'Dark',
},
},
};
```
Expand All @@ -125,19 +135,21 @@ const meta: Meta = {
component: 'demo-button',
parameters: {
backgrounds: {
options: {
maroon: { name: 'Maroon', value: '#400' },
},
// 👇 Set default background value for all component stories
default: 'Gray',
},
},
};

export default meta;
type Story = StoryObj;

export const Large: Story = {
global: {
backgrounds: { value: 'maroon', grid: false },
export const OnDark: Story = {
parameters: {
backgrounds: {
// 👇 Override default background value for this story
default: 'Dark',
},
},
};
```
```
Loading