fix failing test about error. rewrite Sprintf to iterate over runes, rather then doing C-for #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* support for stringer, error * support for %c verb * allow to show <nil> value as in Go fmt.Sprintf * allow to show verb/type mismatches as in Go fmt.Sprintf * add tests
…rather then doing C-for
There was a weird bug...
// {"error: %s", []interface{}{errorToBePrinted}, "error: can I be printed?"},
// ^ BUG panic: reflect: reflect.Value.SetString using value obtained using unexported field
Basically think it had to do with the for loop using []interface{} and
what was being done in the body of the for. The only way was to export
type errorString struct { S /* <- this */ string }
in gnovm/stdlibs/error, or to move the test about error in their own
function; this works:
```
func TestPrintErrors(t *testing.T) {
got := Sprintf("error: %s", errors.New("can I be printed?"))
expectedOutput := "error: can I be printed?"
if got != expectedOutput {
t.Errorf("got %q, want %q.", got, expectedOutput)
}
}
```
* support for stringer, error * support for %c verb * allow to show <nil> value as in Go fmt.Sprintf * allow to show verb/type mismatches as in Go fmt.Sprintf * add tests
grepsuzette
force-pushed
the
improve_ufmt
branch
from
f473be3
to
b9c31a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.