Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: full ng refacto #15

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

wip: full ng refacto #15

wants to merge 22 commits into from

Conversation

douglasduteil
Copy link
Contributor

~~ WIP DON4T MERGE THIS~~

~~ WIP DON4T MERGE THIS~~

  • fix router problem with the angular-ui-router@next
  • add ava + jsdom testing
  • refacto to component first the root of the app
  • add routing to representation (url like : "nso/explore/express/dependency-graph")
  • add registry mocks for future testing
  • make a durty d3 implementation of the wanted behavior

Closes #9

gregoryruiz and others added 21 commits April 13, 2017 02:04
@gregoryruiz
✨ add a d3 renderer with mock datas
bcf70af
@douglasduteil
chore(pkg): add testing stack
48b02c9
@douglasduteil
SAVE working refacto
8256034
@douglasduteil
SAVE adding more test
2c9703b
@douglasduteil
wip-full-ng-refacto
12b75b8
@gregoryruiz
Merge branch 'wip-full-ng-refacto' of https://github.com/douglasdutei…
910c9f6 
…l/nso into douglasduteil-wip-full-ng-refacto

# Conflicts:
#	package.json
#	src/nso/nso.module.html
#	src/nso/presenter/angular/app.component.scss
@gregoryruiz
🎨 extra typing & renaming
846d1f2
@gregoryruiz
🔥 delete core.module
19d76a8
@gregoryruiz
🎨 simplify module id logic
5a6f640
@gregoryruiz
🎨 refactor dependencyWheel
ff9e32d
@paulsouche
fix(dev): bootstrap
cd13f8f
@paulsouche
chore(deps): update
3a4b759
@paulsouche
chore(ts): better config
f731a05
@gregoryruiz
Merge pull request #10 from paulsouche/paulsouche-wip
4c820dc 
paulsouche wip
@paulsouche
feat: add examples
442937f
@gregoryruiz
Merge pull request #11 from paulsouche/feat-examples
6e7bc8b 
✏️ add SOLID examples

- resource: https://github.com/ryanmcdermott/clean-code-javascript#solid
@douglasduteil
test(fixtures): add all chalk dependencies
5d57718
@douglasduteil
chore(routing): replace angular-ui-router by @uirouter/angularjs
38680b3
@douglasduteil
chore(webpack): use minial stats
4e03538 
Makes the output less verbose
@gregoryruiz
Merge pull request #12 from douglasduteil/chore-routing-replace-angul…
a1d321c 
…ar-ui-router-by-uirouter-angularjs

🔧 (routing): replace angular-ui-router by @uirouter/angularjs
@gregoryruiz
Merge pull request #13 from douglasduteil/test-fixtures-add-all-chalk…
b90dbbf 
…-dependencies

🔧 (test): add all chalk dependencies
@douglasduteil
Copy link
Contributor Author

🆙

@gregoryruiz I'm close to it :)

nso-2017-05-15 21-45

@douglasduteil
Copy link
Contributor Author

douglasduteil commented May 15, 2017 •
edited
Loading

🆙

nso-2017-05-15 22-28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@douglasduteil @gregoryruiz @paulsouche