-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use pnpm instead npm #852
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 32 32
Lines 751 751
Branches 249 249
=======================================
Hits 697 697
Misses 53 53
Partials 1 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@await-ovo very good thank you! Could you try to run lerna? You will be blocked on npm but everything else should work right? |
Because I'm not familiar with lerna, do I need to run
|
I think we should verify that the workspace protocol is replaced with the specific version when the package is released. |
@await-ovo I think I will merge and try to make a release. Thanks! |
Summary
The main advantages of using pnpm are:
save local disk space
improve installation speed
avoid the problem that the first
npm run build
of a newly cloned repository has a high probability of error(It often occurs in our ci process):Test plan
pnpm install
, the build and test both succeed.Because netlify always fails for some reason when deployed (local is fine), Keep the website still using npm.