Skip to content

Commit

Permalink
Remove phpunit-bridge specific annotations
Browse files Browse the repository at this point in the history
The phpunit-bridge has been removed in doctrine#3643, so these no longer serve
any purpose. The tests themselves are kept since they check that there
is no crash when using an unknown option, and do not need a phpunit
assertion to do so.
  • Loading branch information
greg0ire committed Nov 6, 2019
1 parent 80a45c6 commit 148aafc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions tests/Doctrine/Tests/DBAL/Functional/PDOStatementTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ protected function setUp() : void
$this->connection->getSchemaManager()->dropAndCreateTable($table);
}

/**
* @group legacy
* @expectedDeprecation Using a PDO fetch mode or their combination (%d given) is deprecated and will cause an error in Doctrine 3.0.
*/
public function testPDOSpecificModeIsAccepted() : void
{
$this->connection->insert('stmt_test', [
Expand Down
8 changes: 0 additions & 8 deletions tests/Doctrine/Tests/DBAL/Schema/ColumnTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,21 +62,13 @@ public function testToArray() : void
self::assertEquals($expected, $this->createColumn()->toArray());
}

/**
* @group legacy
* @expectedDeprecation The "unknown_option" column option is not supported, setting it is deprecated and will cause an error in Doctrine 3.0
*/
public function testSettingUnknownOptionIsStillSupported() : void
{
$this->expectNotToPerformAssertions();

new Column('foo', $this->createMock(Type::class), ['unknown_option' => 'bar']);
}

/**
* @group legacy
* @expectedDeprecation The "unknown_option" column option is not supported, setting it is deprecated and will cause an error in Doctrine 3.0
*/
public function testOptionsShouldNotBeIgnored() : void
{
$col1 = new Column('bar', Type::getType(Types::INTEGER), ['unknown_option' => 'bar', 'notnull' => true]);
Expand Down

0 comments on commit 148aafc

Please sign in to comment.