Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the 3.30 had some wrong #383

Closed
chuangwei opened this issue Jun 1, 2020 · 7 comments
Closed

the 3.30 had some wrong #383

chuangwei opened this issue Jun 1, 2020 · 7 comments

Comments

@chuangwei
Copy link

image

@ZachSaucier
Copy link
Member

Thanks for catching that. You can replace that line with the following and it should fix the error. We'll make sure that's in the next update.

path?: gsap.SVGPathValue | gsap.TweenValue | gsap.Point2D[]| gsap.PathObject[];

@Yanduz
Copy link

Yanduz commented Jun 3, 2020

Yes, I also have this problem on Angular 9.
Xnip2020-06-04_01-55-59

@salomontiago
Copy link

I'm with this problem too.

@jvanoostveen
Copy link

It is keeping us from updating, as I can not manually change this file on each install (build server / developer machine). As it seems such a trivial fix, please provide a patch release with it.
(I'm still very happy the typings are now shipped with GSAP) :)

@jackdoyle
Copy link
Member

Yep, we'll be releasing a patch before the weekend. Sorry about the hassle, and thanks for your patience.

@jvanoostveen
Copy link

Great! I'll pick it up on my update-Monday.

jackdoyle added a commit that referenced this issue Jun 5, 2020
- NEW: ScrollTrigger.batch() method that eliminates the need for something like IntersectionObserver in cases where you want to stagger the animations of elements as they enter the viewport.

- NEW: ScrollTrigger now recognizes an onRefreshInit callback which can be useful in advanced situations where you want to reset positioning of elements just for the calculation of the start/end. If you return a gsap.set() call (or any GSAP animation, but it really only makes sense to do a gsap.set()), it'll actaully revert it automatically when the refresh finishes!

- NEW: Any "refreshInit" listener can [optionally] return a gsap.set() call that'll get reverted as soon as the refresh finishes. Super useful for resetting positions just for the refresh() measurements.

- IMPROVED: ScrollTrigger is now compatible with Internet Explorer and it no longer relies on the "name" being implicity defined. This also fixes some problems that occured in bundlers. See #385 (comment)

- FIXED: if you refresh a page after scrolling down, ScrollTrigger may call the onEnter for everything ABOVE that position (including triggers that are off-screen). Now it only fires the onEnter for triggers that are truly inbetween their start and end positions.

- FIXED: here were a few TypeScript definition file problems. See #383 and #338

- FIXED: Various problems with ScrollTrigger not updating or refreshing properly in certain edge cases.

- FIXED: in some rare cases, an error could be thrown by Draggable or MotionPathPlugin if you tried animating/dragging an element with an ancestor element that has been interacted with by GSAP but NOT related to transforms. See https://greensock.com/forums/topic/24318-nuxtjs-draggable-error-cacherendertransform-is-not-a-function/

- FIXED: if a nested tween gets overwritten INSIDE a stagger tween, it now adjusts the duration of that parent tween when appropriate. For example, if the last staggered tween gets killed, it should shorten the duration of the parent tween.
@jackdoyle
Copy link
Member

This should be resolved in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants