Migrate to monorepo for CI #220
Conversation
|
This PR should be merged after the corresponding PR in gp-extensions-ci is merged. |
+1. |
concourse/test.sh
Outdated
| sudo passwd --delete gpadmin # for `su gpadmin` in start_gpdb | ||
| echo 'alias su="sudo su"' >>"$HOME/.bashrc" | ||
| source "$HOME/.bashrc" # for `alias su` | ||
| start_gpdb |
There was a problem hiding this comment.
why not putting start_gpdb to pre_test.sh like others? https://github.com/pivotal/advanced-password-check/blob/gpdb/concourse/pre_test.sh
pre_test.shruns with root permission, no need to hack thesu/sudoanymore- it will add
sourceto.bashrc, so everything will be set up when gpadmin login. - Ideally, things in
pre_test.shdo setup things, and runs only once. Sotest.shcan be run again when hijack to the concourse.
There was a problem hiding this comment.
I totally agree that it is good to make test.sh idempotent. Working on it.
There was a problem hiding this comment.
test.sh is modified to be idempotent. I tried manually and it seems to work.
There was a problem hiding this comment.
Any special reason why not just follow the convention to have a pre_test.shto start gpdb there?
There was a problem hiding this comment.
| source "$CI_REPO_DIR/common/entry_common.sh" | ||
| sudo passwd --delete gpadmin # for `su gpadmin` in start_gpdb | ||
| if [[ "$(source /etc/os-release && echo "$ID")" == "ubuntu" ]]; then | ||
| su () { |
There was a problem hiding this comment.
I don't like this kind of hack. 🤣
No description provided.