Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greenkeeper login tries to open two tabs #143

Closed
steveklabnik opened this issue Feb 29, 2016 · 4 comments
Closed

greenkeeper login tries to open two tabs #143

steveklabnik opened this issue Feb 29, 2016 · 4 comments

Comments

@steveklabnik
Copy link

When running 'greenkeeper login' just now, it attempted to open two tabs: one with the url "https" and the other with an escaped version of the rest of the URL.
@steveklabnik
Copy link
Author

... it looks like this may actually be a bug in open, not greenkeeper itself.

@steveklabnik
Copy link
Author

.... and it looks like open is basically unmaintained, so it's not likely to actually get fixed.

Anyway, I'll leave this open just in case, but feel free to close if this is one of those things that's just gonna be a thing. It's easy enough to work around.

@steveklabnik steveklabnik mentioned this issue Feb 29, 2016
Open
@boennemann
Copy link
Member

Hey @steveklabnik,

happy to see you're giving Greenkeeper a try.

As far as I can tell there are three modules out there to open things: "open", "opn", and "opener".
"open" appears to have quite a few problems, so swapping that out sounds like a good idea anyway.
Unfortunately "opn" prevents the process from exiting so it doesn't really improve things. It looks like "opener" works well though – can you confirm this on your machine?

If things are working on your side I'm happy to release a new version with the new module.

Best,
Stephan

steveklabnik added a commit to steveklabnik/greenkeeper that referenced this issue Mar 1, 2016
@steveklabnik
Migrate open to opener
520c1c0 
open is apparently not maintained, and has a number of bugs. Opener
is a drop-in replacement, other than the name of the package.

Fixes greenkeeperio#143
@steveklabnik steveklabnik mentioned this issue Mar 1, 2016
Closed
@steveklabnik
Copy link
Author

It does, I just opened a PR. Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @boennemann