fix(hasLockfileCommit): specify origin when fetching #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagoro9
commented
Jul 16, 2018
| @@ -31,7 +31,7 @@ module.exports = { | |||
| // console.log(`git config --replace-all remote.origin.fetch +refs/heads/*:refs/remotes/origin/*`) | |||
| exec(`git config --replace-all remote.origin.fetch +refs/heads/*:refs/remotes/origin/*`) | |||
| // console.log(`git fetch`) | |||
| exec(`git fetch`) | |||
| exec(`git fetch gk-origin`) | |||
There was a problem hiding this comment.
It would be ideal to have this gk-origin value stored isomewhere, as it is referenced here and in upload.js but not sure where to put it.
janl
approved these changes
Jul 17, 2018
|
excellent, thanks! |
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This command appears to be failing for a couple people, as noted in #164. Would opening a new issue be more helpful or is this already being investigated? |
|
I'm looking at 164, but I ran out of time to day and I'm off work now. I'll be looking at this again tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more context in #164 (comment)
When configuring the remote to use
GH_TOKENinupload.jsit is only done for thegk-originremote, but then ingit-helpers#hasLockfileCommitagit fetchis done, which can fail if there is aoriginremote defined, as this one is not configured withGH_TOKEN.This PR updates
hasLockfileCommitto make the fetch fromgk-origin.