Monorepos #140
Merged
Monorepos #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janl
requested review from
boennemann,
hulkoba,
gr2m,
rmehner,
espy,
Realtin,
finnp and
christophwitzko
|
you can install https://github.com/apps/wip on this repo to have pull requests blocked automatically while you have "WIP" or "DO NOT MERGE" in the title :) |
janl
force-pushed
the
feat/monorepos
branch
4 times, most recently
from
7bf2627
to
f4269e5
Compare
janl
force-pushed
the
feat/monorepos
branch
12 times, most recently
from
58553c6
to
58658f2
Compare
|
TODO:
|
BREAKING CHANGE: This now works with monorepos, it’s a big refactor, that’s why we make it a new semver-major release when it lands, just so that existing users won’t get tripped up by little changes. However, the design goal here is to be as backwards compatible as possible.
…ommit on the branch
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hello everyone (and especially @mAAdhaTTah , who asked): this is now released as Thanks! |
patkub
pushed a commit
to patkub/greenkeeper-lockfile
that referenced
this pull request
Jun 22, 2018
feat: support for monorepos and dependencies from monorepos BREAKING CHANGE: multiple breaking changes, see list below. - needs testing with CI services other than TravisCI - CI Environment Variable needed for default branches other than `master`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly done, but do not merge yet, before we’ve had some more eyes on this 👀
💥 Boom, monorepo support, complete with tests.
This is in anticipation of monorepo support landing in Greenkeeper soonish, but we won’t merge this before then.
Firstly, this commits adds an integration test suite that allows us to test different types of repositories.
Secondly. instead of operating on the top level
./package.jsonand assorted lock files, operations are now split into three distinct steps:package.jsonfile in./or sub directories:This is a big change, please review thoroughly.
This also will be a semver-major update, just to make sure we don’t trip anyone up with a subtle change.