apply some Gigascience copyeditor changes #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimmel
commented
Jan 12, 2024
| While predictions based primarily on degree may be acceptable for some tasks, generating less obvious insights from networks requires drawing inferences from the specific connections and network structure between nodes. | ||
| Model evaluation is challenging in this context: nonspecific or trivial predictions can dominate performance evaluations and may actually be correct, even if they are not the desired outputs of the predictive model. | ||
| For example, predicting that the highest degree node in a network shares edges with the remaining nodes to which it is not connected will often lead to many correct predictions, despite this prediction being generic to all other nodes in the network. | ||
|
|
||
| Degree is important in edge prediction, but it can cause undesired effects. | ||
| Degree-based features should often be included in the interpretation of predictions to disentangle desired from non-desired effects and to effectively evaluate and compare predictive models. | ||
| Degree-based features should often be included in the interpretation of predictions to disentangle desired from undesired effects and to effectively evaluate and compare predictive models. |
There was a problem hiding this comment.
we might want to make this change (nondesired --> undesired) in the Gigascience version as well
|
AppVeyor build 1.0.82 |
zietzm
approved these changes
Jan 12, 2024
Co-authored-by: Michael Zietz <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
[ci skip] This build is based on 084aa98. This commit was created by the following CI build and job: https://github.com/greenelab/xswap-manuscript/commit/084aa987338d038f11579641fa4b9e30e6e74826/checks https://github.com/greenelab/xswap-manuscript/actions/runs/7506777009
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
[ci skip] This build is based on 084aa98. This commit was created by the following CI build and job: https://github.com/greenelab/xswap-manuscript/commit/084aa987338d038f11579641fa4b9e30e6e74826/checks https://github.com/greenelab/xswap-manuscript/actions/runs/7506777009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #69 (comment)