Minor changes for recent version 2.0 updates #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the contribution listed in metadata.yaml
|
AppVeyor build 1.0.72 for commit be21800 by @agitter is now complete. The rendered manuscript from this build is temporarily available for download at: |
agitter
commented
Mar 15, 2020
| We continued using the open repository on the GitHub version control platform ([`greenelab/deep-review`](https://github.com/greenelab/deep-review)) [@url:https://github.com/greenelab/deep-review], which was established to write the Version 1.0 manuscript. {% for v2, authors in manubot.authors|groupby('v2') %}{% if v2|length %}{{ v2 }}: {% for author in authors %}{{author.name }}{%- if not loop.last -%}, {%- endif -%}{% endfor %}. {% endif %}{% endfor %} | ||
| We continued using the open repository on the GitHub version control platform ([`greenelab/deep-review`](https://github.com/greenelab/deep-review)) [@url:https://github.com/greenelab/deep-review], which was established to write the version 1.0 manuscript. | ||
| {% for v2, authors in manubot.authors|groupby('v2') %} | ||
| {% if v2|length %}{{ v2 }}: {% for author in authors %}{{author.name }}{% if not loop.last %}, {% endif %}{% endfor %}. {% endif %} |
There was a problem hiding this comment.
It's hard to see with the added newlines, but removing some - here added spaces between the authors:
|
AppVeyor build 1.0.73 for commit b9e8a66 by @agitter is now complete. The rendered manuscript from this build is temporarily available for download at: |
|
🎲 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
[ci skip] This build is based on 5dcf0da. This commit was created by the following CI build and job: https://github.com/greenelab/deep-review/commit/5dcf0daef5149fb9d1d1fca11e90ce9cdf4152bc/checks https://github.com/greenelab/deep-review/runs/56681192
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
[ci skip] This build is based on 5dcf0da. This commit was created by the following CI build and job: https://github.com/greenelab/deep-review/commit/5dcf0daef5149fb9d1d1fca11e90ce9cdf4152bc/checks https://github.com/greenelab/deep-review/runs/56681192
|
My Jinja whitespace fiddling added unintended newlines: Something to clean up in the next pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cgreene's reign as first author is (probably) over!
This pull request has minor updates that follow up on #986, #997, #998, #999.
If there is a simple answer to #998 (comment) about v1 authors whose COIs change, I can add that here before merging.