Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Mapping via collections.abc #99

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Access Mapping via collections.abc #99

merged 3 commits into from
Feb 25, 2019

Conversation

wiegandm
Copy link
Member

The Collections Abstract Base Classes were moved from the collections
module to the collections.abc module in Python 3.3. Using them via the
collections module was deprecated in Python 3.7 and will stop working
in Python 3.8, so the isinstance calls in python-gvm should be
adjusted accordingly.
Checklist:

  • Tests N/A
  • CHANGELOG Entry
  • Documentation N/A

The Collections Abstract Base Classes were moved from the `collections`
module to the `collections.abc` module in Python 3.3. Using them via the
`collections` module was deprecated in Python 3.7 and will stop working
in Python 3.8, so the `isinstance` calls in `python-gvm` should be
adjusted accordingly.

For reference, this the warning shown when running the code in Python
3.7:
```
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working
```
@wiegandm wiegandm requested review from bjoernricks and a team February 25, 2019 08:34
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          10       10           
  Lines        2412     2412           
=======================================
  Hits         2320     2320           
  Misses         92       92
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 99.58% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3c227...45aa23a. Read the comment docs.

@bjoernricks bjoernricks merged commit 668af95 into greenbone:master Feb 25, 2019
@wiegandm wiegandm deleted the collections_abc branch February 26, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants