Additional tests #85
Merged
Additional tests #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
added
the
work in progress
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
===========================================
+ Coverage 59.5% 77.16% +17.65%
===========================================
Files 10 10
Lines 2235 2308 +73
===========================================
+ Hits 1330 1781 +451
+ Misses 905 527 -378
Continue to review full report at Codecov.
|
Also update docstring about the expected ranges.
Maybe in future the values have to be checked...
Ensure schedule_period to be an integer greater or equal 0
It shouldn't be necessary to export several credentials in aspecific format in one request. A user should request a format for only one credential at once.
bjoernricks
removed
the
work in progress
|
This PR includes tests for all get commands now so it should be merged |
This will allow to reuse the code for modify_alert.
Fix order of key and value for method, condition and event data of modify_alert
Add validation for event, condition and method combinations to modify_alert.
wiegandm
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.