Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send correct XML for get_settings #80

Merged
merged 4 commits into from
Dec 17, 2018
Merged

Send correct XML for get_settings #80

merged 4 commits into from
Dec 17, 2018

Conversation

wiegandm
Copy link
Member

The get_settings method previously sent get_schedules instead of the correct GMP command.

This PR provides the unit test used for confirming this bug, the bug fix, a CHANGELOG entry and a unit test for the get_setting (singular) method.

@wiegandm wiegandm requested review from bjoernricks and a team December 17, 2018 11:50
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #80 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   57.84%   58.11%   +0.27%     
==========================================
  Files          10       10              
  Lines        2218     2218              
==========================================
+ Hits         1283     1289       +6     
+ Misses        935      929       -6
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 53.53% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c7f9b...d815e2e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #80 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   57.84%   58.11%   +0.27%     
==========================================
  Files          10       10              
  Lines        2218     2218              
==========================================
+ Hits         1283     1289       +6     
+ Misses        935      929       -6
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 53.53% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c7f9b...d815e2e. Read the comment docs.

@bjoernricks bjoernricks merged commit 68b96d0 into greenbone:master Dec 17, 2018
@wiegandm wiegandm deleted the get_settings branch December 18, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants