Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gmpv9 #166

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Improve gmpv9 #166

merged 5 commits into from
Oct 16, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Oct 16, 2019 •
edited
Loading

  • Use policy_id instead of audit_id for create_audit
  • Make policy_id optional for create_policy
  • Update docstrings

Checklist:

@bjoernricks
Rename audit_id argument to policy_id
39420e3 
Update create_audit method of Gmpv9. We are creating an audit for a
specific policy.
@bjoernricks
Update create_policy method
6e0f2a9 
Make policy_id optional and use the empty scan config id as default when
creating a new policy. We are doing the same in GSA.
@bjoernricks
Update docstrings for create_tls_certificate
2ae62dd
@bjoernricks
Add Gmpv9 get_tls_certificate method
01c4ba7 
Allow to request a single tls certificate for GMP 9.
@bjoernricks
Add changelog entries
ce78819
@bjoernricks bjoernricks marked this pull request as ready for review October 16, 2019 08:52
@bjoernricks bjoernricks merged commit 0bd58c6 into greenbone:master Oct 16, 2019
@bjoernricks bjoernricks deleted the improve-gmpv9 branch March 31, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @wiegandm