Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend InvalidArgument and RequiredArgument error classes #134

Merged
merged 4 commits into from
Jun 19, 2019
Merged

Extend InvalidArgument and RequiredArgument error classes #134

merged 4 commits into from
Jun 19, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jun 19, 2019 •
edited
Loading

Allow to pass function and argument name parameters.

Checklist:

@bjoernricks
Extend InvalidArgument and RequiredArgument errors
6ca3eb3 
Allow to pass a optional argument and function name parameters to the
error constructors.

Closes #91
@bjoernricks
Fix Gmpv7 for InvalidArgument changes
5326fd0
@bjoernricks
Update Gmpv8 for new error API
6928e18 
Pass function and argument args to InvalidArgument and RequiredArgument
errors.
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #134 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   96.65%   96.68%   +0.03%     
==========================================
  Files          10       10              
  Lines        2631     2655      +24     
==========================================
+ Hits         2543     2567      +24     
  Misses         88       88
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 99.74% <ø> (ø) ⬆️
gvm/errors.py 100% <100%> (ø) ⬆️
gvm/protocols/gmpv8.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2bdb5...6928e18. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #134 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   96.65%   96.68%   +0.03%     
==========================================
  Files          10       10              
  Lines        2631     2655      +24     
==========================================
+ Hits         2543     2567      +24     
  Misses         88       88
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 99.74% <ø> (ø) ⬆️
gvm/errors.py 100% <100%> (ø) ⬆️
gvm/protocols/gmpv8.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2bdb5...6928e18. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2019 •
edited
Loading

Codecov Report

Merging #134 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   96.65%   96.68%   +0.03%     
==========================================
  Files          10       10              
  Lines        2631     2655      +24     
==========================================
+ Hits         2543     2567      +24     
  Misses         88       88
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 99.74% <ø> (ø) ⬆️
gvm/errors.py 100% <100%> (ø) ⬆️
gvm/protocols/gmpv8.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2bdb5...44a72f7. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review June 19, 2019 06:39
@bjoernricks bjoernricks requested a review from a team June 19, 2019 06:39
@bjoernricks bjoernricks merged commit 4880db3 into greenbone:master Jun 19, 2019
@bjoernricks bjoernricks deleted the finalize-gmp8 branch June 19, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @wiegandm