Finalize gmp8 part 2 #133
Merged
Finalize gmp8 part 2 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the link to the documentation more prominent to the top of the README. Extend the section by mentioning the README only gives a short overview.
Using enums is safer and easier to extend.
Allow to create password only credentials in GMPv8 Closes #96
* The make_unique argument got dropped from create_filter * Add a FilterType enum
GMPv8 adds filter types for host, operating system, ticket and vulnerability Related to #97
Drop the make_unique argument from create_target because it got dropped from the protocol too. Fixes #97
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 96.56% 96.65% +0.08%
==========================================
Files 10 10
Lines 2564 2631 +67
==========================================
+ Hits 2476 2543 +67
Misses 88 88
Continue to review full report at Codecov.
|
wiegandm
requested changes
Jun 19, 2019
Co-Authored-By: Michael Wiegand <[email protected]>
wiegandm
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: