Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude tests #119

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Exclude tests #119

merged 2 commits into from
Apr 24, 2019

Conversation

qha
Copy link
Contributor

@qha qha commented Apr 24, 2019 •
edited
Loading

Exclude tests from installation.

Also tweak pydoc for get_protocol_version.

Checklist:

  • Tests n/a
  • CHANGELOG Entry
  • Documentation n/a

@qha qha requested a review from a team April 24, 2019 08:29
@qha qha changed the title Wip: Exclude tests Exclude tests Apr 24, 2019
bjoernricks
bjoernricks approved these changes Apr 24, 2019
View reviewed changes
gvm/protocols/ospv1.py
@@ -77,10 +77,10 @@ def create_vt_selection_element(_xmlvtselection, vt_selection):
class Osp(GvmProtocol):
@staticmethod
def get_protocol_version():
"""Allow to determine the Open Scanner Protocol version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@bjoernricks bjoernricks merged commit 1154e6a into greenbone:master Apr 24, 2019
@qha qha deleted the exclude-tests branch April 24, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qha @bjoernricks