Change: Reuse matches in CPE match strings API #1082
Merged
+109
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timopollmeier
force-pushed
the
reduce-cpe-match-mem-usage
branch
2 times, most recently
from
27656e9 to
3856e17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
+ Coverage 90.31% 90.33% +0.01%
==========================================
Files 108 108
Lines 7188 7198 +10
Branches 815 817 +2
==========================================
+ Hits 6492 6502 +10
Misses 491 491
Partials 205 205 ☔ View full report in Codecov by Sentry. |
bjoernricks
requested changes
Jan 7, 2025
@bjoernricks Due to time constrains, @timopollmeier wanted to move tests to "later" ...! |
|
That's not a good idea at all |
|
I know. |
|
I've added a test case for the caching and will add tests to the CPE match downloader in greenbone-scap if there aren't any more urgent fixes required for it. |
bjoernricks
approved these changes
Jan 9, 2025
When parsing the CPE match string JSON from the NVD API, the matching CPEs are cached and reused if identical ones appear in another match string. This can save memory when processing a large amount of CPE match strings with duplicate matches.
timopollmeier
force-pushed
the
reduce-cpe-match-mem-usage
branch
from
ee0e0fd to
ced864f
Compare
Conventional Commits Report
🚀 Conventional commits found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When parsing the CPE match string JSON from the NVD API, the matching CPEs are cached and reused if identical ones appear in another match string.
Why
This can save memory when processing a large amount of CPE match strings with duplicate matches.
References
GEA-820
Checklist