Easier testing for update-header main function

pontos/updateheader/updateheader.py

@@ -12,7 +12,7 @@
 import sys
 from dataclasses import dataclass
 from pathlib import Path
-from typing import Optional, Union
+from typing import Optional, Sequence, Union
 
 from pontos.errors import PontosError
 from pontos.git import Git
@@ -298,8 +298,8 @@ def _compile_copyright_regex(company: Union[str, list[str]]) -> re.Pattern:
     return re.compile(rf"{c_str}.*? {d_str}?-? ?{d_str}? ({'|'.join(company)})")
 
 
-def main() -> None:
-    parsed_args = parse_args()
+def main(args: Optional[Sequence[str]] = None) -> None:
+    parsed_args = parse_args(args)
     exclude_list = []
     year: str = parsed_args.year
     license_id: str = parsed_args.license_id
@@ -349,7 +349,7 @@ def main() -> None:
             except PontosError:
                 term.warning(
                     f"{file}: Could not get date of last modification"
-                    f" using git, using {year} instead."
+                    f" via git, using {year} instead."
                 )
 
         try:

tests/updateheader/test_header.py

@@ -463,25 +463,17 @@ def setUp(self) -> None:
         self.args = Namespace()
         self.args.company = "Greenbone AG"
 
-    @patch("pontos.updateheader.updateheader.parse_args")
-    def test_main(self, argparser_mock):
-        self.args.year = "2021"
-        self.args.changed = False
-        self.args.license_id = "AGPL-3.0-or-later"
-        self.args.files = ["test.py"]
-        self.args.directories = None
-        self.args.verbose = 0
-        self.args.log_file = None
-        self.args.quiet = False
-        self.args.cleanup = False
-
-        argparser_mock.return_value = self.args
-
+    def test_main(self):
+        args = [
+            "--year",
+            "2021",
+            "--license",
+            "AGPL-3.0-or-later",
+            "--files",
+            "test.py",
+        ]
         with redirect_stdout(StringIO()):
-            code = True if not main() else False
-
-        # I have no idea how or why test main ...
-        self.assertTrue(code)
+            main(args)
 
     @patch("sys.stdout", new_callable=StringIO)
     @patch("pontos.updateheader.updateheader.parse_args")
@@ -508,33 +500,30 @@ def test_main_never_happen(self, argparser_mock, mock_stdout):
             ret,
         )
 
-    @patch("sys.stdout", new_callable=StringIO)
-    @patch("pontos.updateheader.updateheader.parse_args")
-    def test_update_file_changed(self, argparser_mock, mock_stdout):
-        self.args.year = "1995"
-        self.args.license_id = "AGPL-3.0-or-later"
-        self.args.changed = True
-        self.args.directories = None
-        self.args.verbose = 0
-        self.args.log_file = None
-        self.args.quiet = False
-        self.args.cleanup = False
-
-        argparser_mock.return_value = self.args
+    def test_update_file_changed_no_git(self):
+        args = [
+            "--changed",
+            "--year",
+            "1999",
+            "--files",
+        ]
 
-        with temp_directory(change_into=True) as temp_dir:
+        with (
+            redirect_stdout(StringIO()) as out,
+            temp_directory(change_into=True) as temp_dir,
+        ):
             test_file = temp_dir / "test.py"
-            self.args.files = str(test_file)
+            args.append(str(test_file))
 
-            main()
+            main(args)
 
-            ret = mock_stdout.getvalue()
+            ret = out.getvalue()
 
-            self.assertIn(f"{test_file}", ret)
-            self.assertIn("Could not get date", ret)
-            self.assertIn("of last modification using git,", ret)
-            self.assertIn(f"using {self.args.year} instead.", ret)
-            self.assertIn("File is not existing.", ret)
+            self.assertIn(
+                "Could not get date of last modification via git, "
+                f"using 1999 instead.{test_file}: File is not existing.",
+                ret.replace("\n", ""),
+            )
 
 
 class RemoveOutdatedLinesTestCase(TestCase):