This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Improve log message. #380
Merged
Improve log message. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
added
backport-to-stable
cfi-gb
reviewed
Apr 1, 2021
ospd/scan.py
Outdated
| invalid_exc_hosts, | ||
| "Please check the excluded host list. It contains hosts which " | ||
| "do not belong to the target. This warning can be ignored if " | ||
| "this was done on purpose." |
There was a problem hiding this comment.
Suggested change
| "this was done on purpose." | |
| "this was done on purpose (e.g. to exclude specific hostname)." |
Not absolutely sure but could help to understand the message.
Actually, no host is removed from the excluded_hosts list. Just the amount host is ajusted for the scan progress calculation The excluded_hosts list can have also vhost, which couldn't be part of the target.
jjnicola
force-pushed
the
excluded-vhost-msg
branch
from
571b971
to
584abf9
Compare
ArnoStiefvater
approved these changes
Apr 1, 2021
This was referenced Apr 1, 2021
ArnoStiefvater
added a commit
that referenced
this pull request
Apr 1, 2021
Improve log message. (bp #380)
ArnoStiefvater
added a commit
that referenced
this pull request
Apr 1, 2021
Improve log message. (bp #380)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Improve log message.
Why:
Actually, no host is removed from the excluded_hosts list. Just the
amount host is ajusted for the scan progress calculation
The excluded_hosts list can have also vhost, which couldn't be part
of the target.
How:
Checklist: