This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Add debug level log messages #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #352 +/- ##
==============================================
+ Coverage 73.75% 73.91% +0.15%
==============================================
Files 23 23
Lines 2576 2603 +27
==============================================
+ Hits 1900 1924 +24
- Misses 676 679 +3
Continue to review full report at Codecov.
|
jjnicola
force-pushed
the
more-log-debug
branch
from
9d39ed4
to
a2a583e
Compare
bjoernricks
reviewed
Jan 26, 2021
CHANGELOG.md
Outdated
| @@ -8,6 +8,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ### Added | |||
| - Allow the scanner to update total count of hosts. [#332](https://github.com/greenbone/ospd/pull/332) | |||
| - Add more debug logging. [#352](https://github.com/greenbone/ospd/pull/352) | |||
| - Set end_time for interrupted scans. [#352](https://github.com/greenbone/ospd/pull/352) | |||
There was a problem hiding this comment.
Should this part be put into another separated PR?
bjoernricks
suggested changes
Jan 26, 2021
ospd/ospd.py
Outdated
| def _get_scan_progress_xml(self, scan_id: str): | ||
| """Gets scan_id scan's progress in XML format. | ||
|
|
||
| @return: String of scan progress in xml. |
There was a problem hiding this comment.
Should be
Suggested change
| @return: String of scan progress in xml. | |
| Returns: | |
| String of scan progress in xml. |
ospd/ospd.py
Outdated
| if not is_stopped and progress == ScanProgress.FINISHED: | ||
| self.finish_scan(scan_id) | ||
| elif not is_stopped: | ||
| logger.info( | ||
| "%s: Host scan finished. Progress: %d, " "Status: %s", |
There was a problem hiding this comment.
Suggested change
| "%s: Host scan finished. Progress: %d, " "Status: %s", | |
| "%s: Host scan finished. Progress: %d, Status: %s", |
This changes will be commited in a separate PR.
jjnicola
force-pushed
the
more-log-debug
branch
from
86c7ccd
to
302aae9
Compare
bjoernricks
approved these changes
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add debug level log messages
Why:
For debugging purposes.
How:
Set log level to debug and run a scan.
Checklist: